WebSites: Add default values to required parameters of BackupSchedule#888
Merged
veronicagg merged 2 commits intoAzure:masterfrom Jan 31, 2017
Merged
WebSites: Add default values to required parameters of BackupSchedule#888veronicagg merged 2 commits intoAzure:masterfrom
veronicagg merged 2 commits intoAzure:masterfrom
Conversation
|
Hi @Nking92, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
naveedaz
approved these changes
Jan 30, 2017
veronicagg
suggested changes
Jan 30, 2017
| "frequencyUnit": { | ||
| "description": "How often should be the backup executed (e.g. for weekly backup, this should be set to Day and FrequencyInterval should be set to 7)", | ||
| "description": "The unit of time for how often should be the backup executed (e.g. for weekly backup, this should be set to Day and FrequencyInterval should be set to 7)", | ||
| "default": 0, |
Contributor
There was a problem hiding this comment.
The default value should match one of the enum values listed and not an index.
…m value instead of an index
veronicagg
approved these changes
Jan 31, 2017
|
No modification for NodeJS |
|
No modification for Ruby |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger